Skip to content

Conversation

@weinbe58
Copy link
Member

@weinbe58 weinbe58 commented Oct 8, 2025

Currently, this optimization will accidentally merge lists across basic blocks or regions, which should not happen. I have added code to fix this issue and included some tests as well.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-10-16 18:44 UTC

@weinbe58 weinbe58 requested a review from Roger-luo October 8, 2025 15:24
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11319 10090 89% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/kirin/dialects/ilist/rewrite/flatten_add.py 100% 🟢
TOTAL 100% 🟢

updated for commit: c1d0394 by action🐍

@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Roger-luo Roger-luo merged commit cfffb2f into main Oct 16, 2025
13 checks passed
@Roger-luo Roger-luo deleted the phil/fix-flatten-ilist-add branch October 16, 2025 18:44
Roger-luo pushed a commit that referenced this pull request Oct 16, 2025
Currently, this optimization will accidentally merge lists across basic
blocks or regions, which should not happen. I have added code to fix
this issue and included some tests as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants